Add gunicorn ASGI to conformance tests#218
Conversation
Looks like http2/ASGI has been added to gunicorn (http2 is still in beta), so figured adding these to our conformance suite was reasonable. Ref: https://gunicorn.org/guides/http2 Ref: https://gunicorn.org/asgi Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
stefanvanburen
changed the title
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Not great to have it in both places. Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
| - [Gunicorn](https://gunicorn.org/) - Python WSGI and ASGI HTTP Server | ||
|
|
||
| For WSGI servers: | ||
|
|
||
| - [Gunicorn](https://gunicorn.org/) - Python WSGI HTTP Server | ||
| - [Gunicorn](https://gunicorn.org/) - Python WSGI and ASGI HTTP Server |
There was a problem hiding this comment.
feels a little weird to have this in both places now? 🤷
stefanvanburen
changed the title
|
Still seeing flakes: https://github.com/connectrpc/connect-python/actions/runs/24569274702/job/71837731826#step:8:193, maybe not worth it... |
anuraaga
left a comment
anuraaga
left a comment
There was a problem hiding this comment.
TBH I have been considering many times to remove daphne from the pytest parameters since it is pretty flaky, and I don't think it's commonly used. We shouldn't add another similar one.
Maybe just keep the changes to server.py and not the rest?
eh, doesn't feel super valuable to me to have the code in place but not hooked up in the tests. maybe we just keep this in the back of our mind for if the situation ever improves? Going to close, but will reopen if you feel strongly the other way! |
2 participants
Looks like
http2/ASGI has been added to gunicorn (http2 is still in beta), so figured adding these to our conformance suite was reasonable.edit: Ended up dropping
http2here as still ran into some issues; maybe still valuable to land the ASGI stuff, though?Ref: https://gunicorn.org/guides/http2
Ref: https://gunicorn.org/asgi